Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: changed default ordering of events #255

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

deepansh96
Copy link
Member

@deepansh96 deepansh96 commented Nov 24, 2021

Fixes #254

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@deepansh96 deepansh96 added the cleanup Technical debt / beautification label Nov 24, 2021
@deepansh96 deepansh96 added this to the v0.4.1 milestone Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #255 (8b21533) into master (a98f833) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files         143      144    +1     
  Lines        2668     2672    +4     
=======================================
+ Hits         2587     2591    +4     
  Misses         81       81           
Impacted Files Coverage Δ
entries/migrations/0027_auto_20211124_0702.py 100.00% <100.00%> (ø)
entries/models.py 98.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98f833...8b21533. Read the comment docs.

@deepansh96 deepansh96 merged commit 71f0e73 into master Nov 25, 2021
@deepansh96 deepansh96 deleted the optimizations/watching-events branch November 25, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Technical debt / beautification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default ordering of Events from [-id] to [-updated_at]
2 participants